Kristian Fiskerstrand
2018-05-09 19:41:00 UTC
in
match exptime_delta with
| None -> (None,None)
| Some _ -> (ctime,exptime_delta)
I suspect that the `None` line there should be yielding (ctime,None)
instead of (None,None); in other words, the four lines above should just
in
(ctime,exptime_delta)
The mRindex.ml code is the only place that get_key_exptimes is called,
and looks to handle the Some unpacking safely already, so it should be
safe to change, but I'm not set up to play around with this right now to
confirm and see if there are negative side-effects.
https://bitbucket.org/skskeyserver/sks-keyserver/commits/f187022f7583c56216ca5871c56b0639ad837481match exptime_delta with
| None -> (None,None)
| Some _ -> (ctime,exptime_delta)
I suspect that the `None` line there should be yielding (ctime,None)
instead of (None,None); in other words, the four lines above should just
in
(ctime,exptime_delta)
The mRindex.ml code is the only place that get_key_exptimes is called,
and looks to handle the Some unpacking safely already, so it should be
safe to change, but I'm not set up to play around with this right now to
confirm and see if there are negative side-effects.
springs to mind. The creation time of the self-signature is needed to
use the latest self-sig. But it is so long ago I don't recall if we
checked if it was used everywhere.
--
----------------------------
Kristian Fiskerstrand
Blog: https://blog.sumptuouscapital.com
Twitter: @krifisk
----------------------------
Public OpenPGP keyblock at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3
----------------------------
Divide et impera
Divide and govern